Add conformance test for nested Optional behavior#2240
Closed
BHUVANSH855 wants to merge 1 commit intopython:mainfrom
Closed
Add conformance test for nested Optional behavior#2240BHUVANSH855 wants to merge 1 commit intopython:mainfrom
BHUVANSH855 wants to merge 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
Member
|
Why does this need a new conformance test? The behavior here is obvious and flows from general rules. |
Author
Thanks for the feedback! I understand that this behavior is already covered by general rules, so this test may be redundant. Closing this PR and will look for a more suitable case to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a conformance test for nested Optional types.
Specifically, it verifies that
Optional[Optional[T]]behaves asOptional[T],and ensures that such values are not treated as non-optional types without proper handling.
The test includes:
Optional[Optional[int]]is incorrectly used asintThis helps improve coverage of edge cases related to Optional and None handling
in the typing specification.